[tor-bugs] #17033 [metrics-lib]: failing tests due to system locale
Tor Bug Tracker & Wiki
blackhole at torproject.org
Sat Sep 12 18:09:55 UTC 2015
#17033: failing tests due to system locale
-----------------------------+---------------------
Reporter: iwakeh | Owner: karsten
Type: defect | Status: new
Priority: minor | Milestone:
Component: metrics-lib | Version:
Resolution: | Keywords:
Actual Points: | Parent ID:
Points: |
-----------------------------+---------------------
Comment (by iwakeh):
Yeah, usually there is more to this locale stuff.
Well, that's why I termed the jvmargs for unit-tests "quick fix" :-)
The US-locale wasn't really necessary for the tests; only a consistent
locale setting.
And, changing the code as you suggest seem better, but:
Are there any side-effects? I didn't have time to look closer, where
ParseHelper is used.
If not, your change is the right thing to do.
If ParseHelper should only accommodate the US locale it definitely needs
some tests assuring this.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17033#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list