[tor-bugs] #16983 [Tor Browser]: Favicon requests not isolated if one opens the tab list dropdown

[Tor Bug Tracker & Wiki]

#16983: Favicon requests not isolated if one opens the tab list dropdown
------------------------------+-----------------------------
     Reporter:  someone_else  |      Owner:  tbb-team
         Type:  defect        |     Status:  new
     Priority:  major         |  Milestone:
    Component:  Tor Browser   |    Version:
   Resolution:                |   Keywords:  tbb-linkability
Actual Points:                |  Parent ID:
       Points:                |
------------------------------+-----------------------------

Comment (by arthuredelstein):

 Here's a fix for this bug, for review:

 https://github.com/arthuredelstein/tor-browser/commit/16983

 I changed the `firstparty` attribute semantics somewhat. With this patch,
 if a chrome XUL/HTML element has its `firstparty` attribute set with a
 URI, then that first party URI will apply to all descendant elements. So
 now we simply set `firstparty` on the `tab` element and the `menuitem`
 element and their child `image` elements will automatically receive the
 correct isolation domain.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16983#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online