[tor-bugs] #16909 [Tor Browser]: Adapt Tor Browser bundling to new HTTPS-Everywhere ID beginning with 5.1.0

[Tor Bug Tracker & Wiki]

#16909: Adapt Tor Browser bundling to new HTTPS-Everywhere ID beginning with 5.1.0
-------------------------+-------------------------------------------------
     Reporter:  gk       |      Owner:  gk
         Type:           |     Status:  needs_review
  enhancement            |  Milestone:
     Priority:  normal   |    Version:
    Component:  Tor      |   Keywords:  tbb-gitian, TorBrowserTeam201509R,
  Browser                |  GeorgKoppen201509
   Resolution:           |  Parent ID:
Actual Points:           |
       Points:           |
-------------------------+-------------------------------------------------
Changes (by gk):

 * status:  needs_revision => needs_review


Comment:

 Replying to [comment:14 mcs]:
 > While reviewing the Tor Browser changes, Kathy and I found that the code
 in make_incremental_update.sh that determines whether HTTPS Everywhere has
 changed will also need to be tweaked (the code is near line 140; look for
 https_everywhere_install_rdf). When transitioning from old (no -eff) to
 new, the diff command will exit with 2 due to a missing path. Maybe just
 add a check for the existence of $olddir/$https_everywhere_install_rdf and
 if the directory is missing force HTTPS Everywhere to be updated.

 Good idea. bug_16909_v2 (https://gitweb.torproject.org/user/gk/tor-
 browser.git/commit/?h=bug_16909_v2&id=769e682313bdd3ea26bdbc492c3158e1b0698c28)
 should have that addendum.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16909#comment:15>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online