[tor-bugs] #16769 [Tor]: add two new functions when manually calling --keygen for better management

[Tor Bug Tracker & Wiki]

#16769: add two new functions when manually calling --keygen for better management
-------------------------+-------------------------------------------------
     Reporter:  s7r      |      Owner:  nickm
         Type:  defect   |     Status:  needs_revision
     Priority:  normal   |  Milestone:  Tor: 0.2.7.x-final
    Component:  Tor      |    Version:  Tor: 0.2.7.2-alpha
   Resolution:           |   Keywords:  ed25519, relay, keys,
Actual Points:           |  TorCoreTeam201509, PostFreeze027
       Points:           |  Parent ID:  #16645
-------------------------+-------------------------------------------------

Comment (by s7r):

 Doesn't work as expected.

 When `--newpass` is called it still generates new cert and medium term
 signing key regardless if it doesn't have any, or already has valid ones.
 I come back with my suggestion to make `--newpass` care only about the
 master secret identity key, and don't check or try to generate cert and
 medium term signing key. We are under the assumption that an user calling
 `--newpass` wants to change passphrase/encrypt/decrypt. If cert and medium
 term signing key are also needed, another `--keygen` without `--newpass`
 will do it.

 I get the same error for `--master-key`. It doesn't read it second time
 and reports "Invalid argument". Also, if I call --master-key ~/something
 it will also look for / generate something_public_key.
 $ tor --master-key ~12/test --keygen
 {{{
 Sep 09 08:01:47.690 [warn] No key found in /root/12/test or
 /root/12/test_public_key.
 Sep 09 08:01:47.690 [warn] Missing identity key
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16769#comment:12>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online