[tor-bugs] #16910 [Tor Browser]: Tor Browser app bundle has wrong copyright year (Mac OS)

[Tor Bug Tracker & Wiki]

#16910: Tor Browser app bundle has wrong copyright year (Mac OS)
---------------------------+-----------------------------------------------
     Reporter:  mcs        |      Owner:  tbb-team
         Type:  defect     |     Status:  closed
     Priority:  normal     |  Milestone:
    Component:  Tor        |    Version:
  Browser                  |   Keywords:  tbb-gitian, TorBrowserTeam201509R
   Resolution:  fixed      |  Parent ID:
Actual Points:             |
       Points:             |
---------------------------+-----------------------------------------------
Changes (by gk):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Replying to [comment:2 mcs]:
 > Here is a proposed fix:
 > https://gitweb.torproject.org/user/brade/tor-browser-
 bundle.git/commit/?h=bug16910-01&id=90aa526e3d4de29660e69ad3839a0439d7dc22cc
 > To ensure reproducibility even if someone builds during a different
 calendar year, this patch grabs the year from the date of the last tor-
 browser commit and inserts that as the copyright year on Mac OS.
 > Please review.

 Looks good. Applied to master (commit
 5019358bcac86508260703ae9cd99a4dfd2983e1) and maint-5.0 (commit
 7d0d8bb670f93be292997d6483825f661a29583f).

 > Also, this is not a problem on Windows because the firefox.exe resource
 does not include a year in the copyright field. Maybe we should add "Tor
 Project" to the copyright notices on Windows? I wonder if there is already
 a ticket for that issue.

 I don't think so. Care to file one?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16910#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online