[tor-bugs] #16909 [Tor Browser]: Adapt Tor Browser bundling to new HTTPS-Everywhere ID beginning with 5.1.0

[Tor Bug Tracker & Wiki]

#16909: Adapt Tor Browser bundling to new HTTPS-Everywhere ID beginning with 5.1.0
-------------------------+-------------------------------------------------
     Reporter:  gk       |      Owner:  gk
         Type:           |     Status:  needs_information
  enhancement            |  Milestone:
     Priority:  normal   |    Version:
    Component:  Tor      |   Keywords:  tbb-gitian, TorBrowserTeam201509,
  Browser                |  GeorgKoppen201509
   Resolution:           |  Parent ID:
Actual Points:           |
       Points:           |
-------------------------+-------------------------------------------------

Comment (by gk):

 Short story: the translation submodule is currently breaking our Gitian
 build. Longer story: With the translations being in an own git submodule
 we have two somewhat plausible options:

 1) Initialize the submodule(s) (it turns out there are more but we never
 bothered with them as we don't need them) immediately after fetching the
 source before we start building
 2) Initialize the submodules during the bundling.

 1) is strictly preferable as 2) would mean we need network activity while
 building and downloading this somewhat uncontrolled is sketchy.
 Unforunately, both approaches are failing. The first is failing as the git
 version on Ubuntu Precise is too old to cope with absolute paths to locate
 submodules if we move the repo (which we do)
 {{{
 + cd build/https-everywhere
 + git reset -q --hard
 fatal: Not a git repository: /home/gk/master/gitian-builder/inputs/https-
 everywhere/.git/modules/addon-sdk
 }}}
 https://stackoverflow.com/questions/10144149/git-status-returns-fatal-
 not-a-git-repository-but-git-exists-and-head-has-prop

 `git reset -q --hard` is run by Gitian, we'd need to patch that out and
 fix the paths manually. Not my desired solution tbh.

 2) is failing for me because I can't for some reason not download the
 translations during the build step (which is actually a good property :)
 ). Thus, even if we could fix that I don't want to depend on that while
 building.

 So, what options do we have now:
 3) no translations submodule
 4) bump the min OS version for Gitian builds to Ubuntu 14.04 (should work
 out of the box); Debian oldstable, which we currently support, might work
 as well (have not checked yet)

 Re 4) it should be enough if the host OS is 14.04; doing git things later
 on in a 12.04 environment should be fine (I simulated that by compiling a
 newer git on a 12.04 version doing a `git reset --hard -q` with the older
 one and that did not produce any error)

 I am not happy about 3) nor 4) either. Are there options I've missed?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16909#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online