[tor-bugs] #16790 [Tor]: Tor should reload keys from disk when receiving a SIGHUP

[Tor Bug Tracker & Wiki]

#16790: Tor should reload keys from disk when receiving a SIGHUP
-------------------------+-------------------------------------------------
     Reporter:  s7r      |      Owner:  nickm
         Type:  defect   |     Status:  needs_review
     Priority:  normal   |  Milestone:  Tor: 0.2.7.x-final
    Component:  Tor      |    Version:  Tor: 0.2.7.2-alpha
   Resolution:           |   Keywords:  ed25519, identity, keys,
Actual Points:           |  TorCoreTeam201509, PostFreeze027
       Points:           |  Parent ID:
-------------------------+-------------------------------------------------
Changes (by s7r):

 * status:  needs_revision => needs_review


Comment:

 Fixed in `ed25519_hup_v2` branch `(git-037e8763a7cb6358)`

 Doesn't blindly accept new medium term signing key and cert if something
 is odd, computes and saves to disk the master public key if missing,
 covers the startup cases.

 {{{
 Sep 02 11:33:22.000 [notice] Received reload signal (hup). Reloading
 config and resetting internal state.
 Sep 02 11:33:22.000 [warn] No key found in
 /root/torsrc/data/keys/ed25519_master_id_secret_key or
 /root/torsrc/data/keys/ed25519_master_id_public_key.
 Sep 02 11:33:22.000 [warn] Master public key was absent; inferring from
 public key in signing certificate and saving to disk.

 Cases 2 and 3:
 Sep 02 11:36:36.000 [warn] The signing cert we have was not signed with
 the master key we loaded!
 Sep 02 11:36:36.000 [warn] Problem reloading Ed25519 keys; still using old
 keys.
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16790#comment:13>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online