[tor-bugs] #17218 [Tor]: Move most of "circuit_mark_for_close" into "circuit_free" or "circuit_close_all_marked".

[Tor Bug Tracker & Wiki]

#17218: Move most of "circuit_mark_for_close" into "circuit_free" or
"circuit_close_all_marked".
-------------------------+------------------------------------
 Reporter:  nickm        |          Owner:
     Type:  enhancement  |         Status:  needs_review
 Priority:  Medium       |      Milestone:  Tor: 0.2.8.x-final
Component:  Tor          |        Version:
 Severity:  Normal       |     Resolution:
 Keywords:               |  Actual Points:
Parent ID:  #16764       |         Points:
  Sponsor:  SponsorS     |
-------------------------+------------------------------------
Changes (by dgoulet):

 * severity:   => Normal


Comment:

 This is currently running on my fast relay, we'll see in the coming days
 if any issues arise.

 With master at commit 19e10f95c105a698d3593a1ecfa88a7449a21127, when
 sending SIGTERM to tor, here is a backtrace of an assertion:

 {{{
 Oct 27 14:23:33.000 [notice] Catching signal TERM, exiting cleanly.
 Oct 27 14:23:33.000 [warn] Couldn't find circuit 4107801626 (for channel
 1232)
 Oct 27 14:23:33.000 [err] tor_assertion_failed_(): Bug:
 src/or/circuitmux.c:501: circuitmux_detach_all_circuits: Assertion
 to_remove->muxinfo.policy_data == NULL failed; aborting. (on Tor 0.2.8.0
 -alpha-dev 81b6f18dbef9187b)
 Oct 27 14:23:33.000 [err] Bug: Assertion to_remove->muxinfo.policy_data ==
 NULL failed in circuitmux_detach_all_circuits at src/or/circuitmux.c:501.
 Stack trace: (on Tor 0.2.8.0-alpha-dev 81b6f18dbef9187b)
 Oct 27 14:23:33.000 [err] Bug:
 ./git/tor/src/or/tor(log_backtrace+0x41) [0x7f4d6c206981] (on Tor 0.2.8.0
 -alpha-dev 81b6f18dbef9187b)
 Oct 27 14:23:33.000 [err] Bug:
 ./git/tor/src/or/tor(tor_assertion_failed_+0x94) [0x7f4d6c2145b4] (on Tor
 0.2.8.0-alpha-dev 81b6f18dbef9187b)
 Oct 27 14:23:33.000 [err] Bug:
 ./git/tor/src/or/tor(circuitmux_detach_all_circuits+0x2a1)
 [0x7f4d6c195c91] (on Tor 0.2.8.0-alpha-dev 81b6f18dbef9187b)
 Oct 27 14:23:33.000 [err] Bug:     ./git/tor/src/or/tor(+0xa5cae)
 [0x7f4d6c182cae] (on Tor 0.2.8.0-alpha-dev 81b6f18dbef9187b)
 Oct 27 14:23:33.000 [err] Bug:
 ./git/tor/src/or/tor(channel_free_all+0x8f) [0x7f4d6c18319f] (on Tor
 0.2.8.0-alpha-dev 81b6f18dbef9187b)
 Oct 27 14:23:33.000 [err] Bug:     ./git/tor/src/or/tor(tor_free_all+0x7a)
 [0x7f4d6c11937a] (on Tor 0.2.8.0-alpha-dev 81b6f18dbef9187b)
 Oct 27 14:23:33.000 [err] Bug:     ./git/tor/src/or/tor(tor_cleanup+0x2c)
 [0x7f4d6c1194ec] (on Tor 0.2.8.0-alpha-dev 81b6f18dbef9187b)
 Oct 27 14:23:33.000 [err] Bug:     ./git/tor/src/or/tor(+0x3d664)
 [0x7f4d6c11a664] (on Tor 0.2.8.0-alpha-dev 81b6f18dbef9187b)
 Oct 27 14:23:33.000 [err] Bug:     /usr/lib/x86_64-linux-
 gnu/libevent-2.0.so.5(event_base_loop+0xa7b) [0x7f4d6b76324b] (on Tor
 0.2.8.0-alpha-dev 81b6f18dbef9187b)
 Oct 27 14:23:33.000 [err] Bug:
 ./git/tor/src/or/tor(do_main_loop+0x20d) [0x7f4d6c11884d] (on Tor 0.2.8.0
 -alpha-dev 81b6f18dbef9187b)
 Oct 27 14:23:33.000 [err] Bug:     ./git/tor/src/or/tor(tor_main+0x19ad)
 [0x7f4d6c11c96d] (on Tor 0.2.8.0-alpha-dev 81b6f18dbef9187b)
 Oct 27 14:23:33.000 [err] Bug:     ./git/tor/src/or/tor(main+0x19)
 [0x7f4d6c115ba9] (on Tor 0.2.8.0-alpha-dev 81b6f18dbef9187b)
 Oct 27 14:23:33.000 [err] Bug:     /lib/x86_64-linux-
 gnu/libc.so.6(__libc_start_main+0xf5) [0x7f4d6ab59ec5] (on Tor 0.2.8.0
 -alpha-dev 81b6f18dbef9187b)
 Oct 27 14:23:33.000 [err] Bug:     ./git/tor/src/or/tor(+0x38bfb)
 [0x7f4d6c115bfb] (on Tor 0.2.8.0-alpha-dev 81b6f18dbef9187b)
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17218#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online