[tor-bugs] #12716 [meek]: Make meek-client-torbrowser take the firefox command as a parameter

[Tor Bug Tracker & Wiki]

#12716: Make meek-client-torbrowser take the firefox command as a parameter
------------------------+----------------------------
     Reporter:  dcf     |      Owner:  dcf
         Type:  defect  |     Status:  needs_revision
     Priority:  minor   |  Milestone:
    Component:  meek    |    Version:
   Resolution:          |   Keywords:
Actual Points:          |  Parent ID:
       Points:          |    Sponsor:
------------------------+----------------------------

Comment (by infinity0):

 Hi, any new opinions on this? I've rebased to current master:

 https://github.com/infinity0/meek/compare/upstream...master

 The first four commits were talked about previously. That leaves:

  * [https://github.com/infinity0/meek/commit/43a35d32 43a35d32] This is as
 per ticket:12716#comment:26, plus I added the ability to specify
 ENVVAR=val so that we can include the fix for #13247 on TorBrowser-
 windows. See e.g. [https://github.com/infinity0/tor-browser-
 bundle/commit/b1cb6747 b1cb6747]
  * [https://github.com/infinity0/meek/commit/6b21c416 6b21c416] Here I
 made each platform only support one single behaviour - windows uses the
 "argument list" format, and the other platforms treats `--helper` as an
 executable.
    * I still think this is unnecessary, and that it's more clean to just
 consistently support both options. One can think of the "argument list"
 file as a custom script that meek-client-wrapper knows how to interpret
 and execute. Instead, we can add some comments about why the "single
 script" option is probably unsuitable for Windows.

 Instead of continually attaching patches, I've pushed the corresponding
 edits to TorBrowser here:

 https://github.com/infinity0/tor-browser-bundle/compare/upstream...master

 It includes an example of how to use the "argument list" file for
 TorBrowser on Windows.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/12716#comment:29>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online