[tor-bugs] #17085 [Tor]: Improve coverage on src/common/util_process.c

Tor Bug Tracker & Wiki blackhole at torproject.org
Mon Oct 5 19:09:19 UTC 2015


#17085: Improve coverage on src/common/util_process.c
-----------------------------+----------------------------------
     Reporter:  rjunior      |      Owner:
         Type:  enhancement  |     Status:  needs_revision
     Priority:  normal       |  Milestone:  Tor: 0.2.8.x-final
    Component:  Tor          |    Version:
   Resolution:               |   Keywords:  testing, 028-triaged
Actual Points:               |  Parent ID:
       Points:  small        |    Sponsor:  SponsorS
-----------------------------+----------------------------------

Comment (by olabini):

 I have pushed fixes to the issues identified, and also fixed some space
 issues.

 The reason why there are two calls to clear_waitpid_callback() is because
 the behavior is different if the callback has already been cleared. I now
 test the two cases by verifying that no logs were logged in the first
 case, and that a log happens after the second call.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17085#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list