[tor-bugs] #17237 [Tor]: TLS compilation warnings and unit test failures

[Tor Bug Tracker & Wiki]

#17237: TLS compilation warnings and unit test failures
------------------------+---------------------------------------
     Reporter:  teor    |      Owner:
         Type:  defect  |     Status:  new
     Priority:  normal  |  Milestone:  Tor: 0.2.8.x-final
    Component:  Tor     |    Version:  Tor: unspecified
   Resolution:          |   Keywords:  027-backport 026-backport
Actual Points:          |  Parent ID:
       Points:          |    Sponsor:
------------------------+---------------------------------------

Comment (by rl1987):

 I'm using Mac OS X with LLVM, OpenSSL from their git master
 (67202973cf55eaac021706c183377b8040cf0c20), compiled for 64 bit
 architecture. When attempting to compile current Tor master
 (c9cb5516ab3380f266c7f5db68899cb4cff49202), I get the following errors:

 {{{
   CC       src/common/tortls.o
 In file included from src/common/tortls.c:75:
 ./src/common/tortls.h:139:15: error: static declaration of
       'SSL_SESSION_get_master_key' follows non-static declaration
 STATIC size_t SSL_SESSION_get_master_key(SSL_SESSION *s, uint8_t *out,
               ^
 /usr/local/ssl/include/openssl/ssl.h:1659:15: note: previous declaration
 is here
 __owur size_t SSL_SESSION_get_master_key(const SSL_SESSION *ssl,
               ^
 src/common/tortls.c:2139:49: warning: passing 'const X509 *' (aka
       'const struct x509_st *') to parameter of type 'X509 *'
       (aka 'struct x509_st *') discards qualifiers
       [-Wincompatible-pointer-types-discards-qualifiers]
   if (!(ASN1_TIME_print(bio, X509_get_notBefore(cert)))) {
                                                 ^~~~
 /usr/local/ssl/include/openssl/x509.h:694:38: note: passing argument to
       parameter 'x' here
 ASN1_TIME * X509_get_notBefore(X509 *x);
                                      ^
 src/common/tortls.c:2147:48: warning: passing 'const X509 *' (aka
       'const struct x509_st *') to parameter of type 'X509 *'
       (aka 'struct x509_st *') discards qualifiers
       [-Wincompatible-pointer-types-discards-qualifiers]
   if (!(ASN1_TIME_print(bio, X509_get_notAfter(cert)))) {
                                                ^~~~
 /usr/local/ssl/include/openssl/x509.h:696:36: note: passing argument to
       parameter 'x' here
 ASN1_TIME *X509_get_notAfter(X509 *x);
                                    ^
 src/common/tortls.c:2309:40: warning: passing 'const X509 *' (aka
       'const struct x509_st *') to parameter of type 'X509 *'
       (aka 'struct x509_st *') discards qualifiers
       [-Wincompatible-pointer-types-discards-qualifiers]
   if (X509_cmp_time(X509_get_notBefore(cert), &t) > 0) {
                                        ^~~~
 /usr/local/ssl/include/openssl/x509.h:694:38: note: passing argument to
       parameter 'x' here
 ASN1_TIME * X509_get_notBefore(X509 *x);
                                      ^
 src/common/tortls.c:2314:39: warning: passing 'const X509 *' (aka
       'const struct x509_st *') to parameter of type 'X509 *'
       (aka 'struct x509_st *') discards qualifiers
       [-Wincompatible-pointer-types-discards-qualifiers]
   if (X509_cmp_time(X509_get_notAfter(cert), &t) < 0) {
                                       ^~~~
 /usr/local/ssl/include/openssl/x509.h:696:36: note: passing argument to
       parameter 'x' here
 ASN1_TIME *X509_get_notAfter(X509 *x);
                                    ^
 4 warnings and 1 error generated.
 make[1]: *** [src/common/tortls.o] Error 1
 make: *** [all] Error 2
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17237#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online