[tor-bugs] #17237 [Tor]: TLS compilation warnings and unit test failures

[Tor Bug Tracker & Wiki]

#17237: TLS compilation warnings and unit test failures
------------------------+--------------------------------
     Reporter:  teor    |      Owner:
         Type:  defect  |     Status:  new
     Priority:  normal  |  Milestone:  Tor: 0.2.8.x-final
    Component:  Tor     |    Version:  Tor: unspecified
   Resolution:          |   Keywords:
Actual Points:          |  Parent ID:
       Points:          |    Sponsor:
------------------------+--------------------------------

Comment (by teor):

 And
 {{{
   CC       src/common/src_common_libor_crypto_testing_a-tortls.o
 src/common/tortls.c:1114:35: warning: implicit declaration of function
       'TLS_method' is invalid in C99 [-Wimplicit-function-declaration]
   if (!(result->ctx = SSL_CTX_new(TLS_method())))
                                   ^
 src/common/tortls.c:1114:35: warning: incompatible integer to pointer
 conversion
       passing 'int' to parameter of type 'const SSL_METHOD *' (aka 'const
 struct
       ssl_method_st *') [-Wint-conversion]
   if (!(result->ctx = SSL_CTX_new(TLS_method())))
                                   ^~~~~~~~~~~~
 /opt/local/include/openssl/ssl.h:2131:40: note: passing argument to
 parameter
       'meth' here
 SSL_CTX *SSL_CTX_new(const SSL_METHOD *meth);
                                        ^
 src/common/tortls.c:1388:21: warning: incompatible integer to pointer
 conversion
       initializing 'const SSL_METHOD *' (aka 'const struct ssl_method_st
 *')
       with an expression of type 'int' [-Wint-conversion]
   const SSL_METHOD *m = TLS_method();
                     ^   ~~~~~~~~~~~~
 }}}

 I'm using clang:

 {{{
 Configured with: --prefix=/Applications/Xcode.app/Contents/Developer/usr
 --with-gxx-include-dir=/usr/include/c++/4.2.1
 Apple LLVM version 7.0.0 (clang-700.0.72)
 Target: x86_64-apple-darwin14.5.0
 Thread model: posix
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17237#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online