[tor-bugs] #17237 [Tor]: TLS compilation warnings and unit test failures

[Tor Bug Tracker & Wiki]

#17237: TLS compilation warnings and unit test failures
--------------------+------------------------------------
 Reporter:  teor    |          Owner:
     Type:  defect  |         Status:  new
 Priority:  normal  |      Milestone:  Tor: 0.2.8.x-final
Component:  Tor     |        Version:  Tor: unspecified
 Keywords:          |  Actual Points:
Parent ID:          |         Points:
  Sponsor:          |
--------------------+------------------------------------
 Have these been fixed?

 {{{
   CC       src/test/src_test_test-test_tortls.o
 src/test/test_tortls.c:1394:32: warning: unused variable 'wbuf_c'
       [-Wunused-variable]
   size_t rbuf_c=-1, rbuf_b=-1, wbuf_c=-1, wbuf_b=-1;
                                ^
 src/test/test_tortls.c:1394:21: warning: unused variable 'rbuf_b'
       [-Wunused-variable]
   size_t rbuf_c=-1, rbuf_b=-1, wbuf_c=-1, wbuf_b=-1;
                     ^
 src/test/test_tortls.c:1394:43: warning: unused variable 'wbuf_b'
       [-Wunused-variable]
   size_t rbuf_c=-1, rbuf_b=-1, wbuf_c=-1, wbuf_b=-1;
                                           ^
 src/test/test_tortls.c:1394:10: warning: unused variable 'rbuf_c'
       [-Wunused-variable]
   size_t rbuf_c=-1, rbuf_b=-1, wbuf_c=-1, wbuf_b=-1;
 }}}

 {{{
 tortls/shutdown:
   FAIL src/test/test_tortls.c:1988: assert(ret OP_EQ TOR_TLS_DONE): -8 vs
 0
   [shutdown FAILED]
 tortls/renegotiate: OK
 tortls/finish_handshake: OK
 tortls/handshake: OK
 tortls/write: OK
 tortls/read:
   FAIL src/test/test_tortls.c:2106: assert(ret OP_EQ TOR_TLS_CLOSE): -8 vs
 -3
   [read FAILED]
 tortls/server_info_callback: OK
 tortls/is_server: OK
 tortls/assert_renegotiation_unblocked: Oct 06 04:19:17.673 [err] void
 tor_assertion_failed_(const char *, unsigned int, const char *, const char
 *): Bug: src/common/tortls.c:1761: tor_tls_assert_renegotiation_unblocked:
 Assertion 0 != (options & SSL_OP_ALLOW_UNSAFE_LEGACY_RENEGOTIATION)
 failed; aborting. (on Tor 0.2.8.0-alpha-dev 2ac5e5f61742738a)
 Oct 06 04:19:17.673 [err] Bug: Assertion 0 != (options &
 SSL_OP_ALLOW_UNSAFE_LEGACY_RENEGOTIATION) failed in
 tor_tls_assert_renegotiation_unblocked at src/common/tortls.c:1761. Stack
 trace: (on Tor 0.2.8.0-alpha-dev 2ac5e5f61742738a)
 Oct 06 04:19:17.673 [err] Bug:     0   test
 0x002b0e84 log_backtrace + 68 (on Tor 0.2.8.0-alpha-dev 2ac5e5f61742738a)
 Oct 06 04:19:17.673 [err] Bug:     1   test
 0x002bf077 tor_assertion_failed_ + 183 (on Tor 0.2.8.0-alpha-dev
 2ac5e5f61742738a)
 Oct 06 04:19:17.673 [err] Bug:     2   test
 0x002db2ad tor_tls_assert_renegotiation_unblocked + 93 (on Tor 0.2.8.0
 -alpha-dev 2ac5e5f61742738a)
 Oct 06 04:19:17.673 [err] Bug:     3   test
 0x00156076 test_tortls_assert_renegotiation_unblocked + 70 (on Tor 0.2.8.0
 -alpha-dev 2ac5e5f61742738a)
 Oct 06 04:19:17.673 [err] Bug:     4   test
 0x0019f44a testcase_run_one + 442 (on Tor 0.2.8.0-alpha-dev
 2ac5e5f61742738a)
 Oct 06 04:19:17.673 [err] Bug:     5   test
 0x0019fb88 tinytest_main + 584 (on Tor 0.2.8.0-alpha-dev 2ac5e5f61742738a)
 Oct 06 04:19:17.673 [err] Bug:     6   test
 0x0019ef23 main + 675 (on Tor 0.2.8.0-alpha-dev 2ac5e5f61742738a)
 Oct 06 04:19:17.673 [err] Bug:     7   libdyld.dylib
 0x922416d9 start + 1 (on Tor 0.2.8.0-alpha-dev 2ac5e5f61742738a)
 FAIL src/test/test (exit status: 134)
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17237>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online