[tor-bugs] #17188 [Tor]: Tor should warn users when traveling backwards through time

Tor Bug Tracker & Wiki blackhole at torproject.org
Sun Oct 4 05:43:32 UTC 2015


#17188: Tor should warn users when traveling backwards through time
-----------------------------+-----------------------------------------
     Reporter:  hdevalence   |      Owner:
         Type:  enhancement  |     Status:  reopened
     Priority:  trivial      |  Milestone:  Tor: 0.2.8.x-final
    Component:  Tor          |    Version:
   Resolution:               |   Keywords:  security, 028-triaged, easy
Actual Points:               |  Parent ID:
       Points:  small        |    Sponsor:
-----------------------------+-----------------------------------------
Changes (by teor):

 * priority:  normal => trivial
 * status:  closed => reopened
 * resolution:  implemented =>
 * keywords:  security, 028-triaged => security, 028-triaged, easy


Comment:

 Now that I've read connection_dir_client_reached_eof(), where we also warn
 about inaccurate clocks, I think it would be nice to make both messages
 consistent.

 We could also refactor the message generation so that it's in a common
 function.

 Here's the current code from connection_dir_client_reached_eof():
 {{{
       log_fn(trusted ? LOG_WARN : LOG_INFO,
              LD_HTTP,
              "Received directory with skewed time (server '%s:%d'): "
              "It seems that our clock is %s by %s, or that theirs is %s. "
              "Tor requires an accurate clock to work: please check your
 time, "
              "timezone, and date settings.",
              conn->base_.address, conn->base_.port,
              delta>0 ? "ahead" : "behind", dbuf,
              delta>0 ? "behind" : "ahead");
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17188#comment:12>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list