[tor-bugs] #17701 [metrics-lib]: ExitList descriptor chokes on getUnrecognizedLines()

[Tor Bug Tracker & Wiki]

#17701: ExitList descriptor chokes on getUnrecognizedLines()
-------------------------+-------------------------
 Reporter:  tomlurge     |          Owner:  karsten
     Type:  defect       |         Status:  new
 Priority:  Medium       |      Milestone:
Component:  metrics-lib  |        Version:
 Severity:  Normal       |     Resolution:
 Keywords:               |  Actual Points:
Parent ID:               |         Points:
  Sponsor:               |
-------------------------+-------------------------

Comment (by tomlurge):

 Replying to [comment:14 iwakeh]:
 > Replying to [comment:10 tomlurge]:
 > Could you add your data to github?

 Here you go: https://github.com/tomlurge/mteam/tree/master/data/in

 > After removing the double exitnode line the converter produced the
 wanted json
 > with your old data on github.

 Same here! See below...

 > PS:
 > This is the data I was using:
 >
 https://github.com/tomlurge/mteam/blob/master/docs/rawDataExamples/tordnsel.txt

 Ah! I had forgotten that completely... As you can see in the /data/in
 directory, that is now in the repo, I have one directory with a few
 descriptors per each type and another directory, named 'singles', with one
 descriptot per type. The Tordnsel descriptor in the 'singles' directory is
 the same as in /docs/rawDataExamples.
 Indeed every Tordnsel descriptot contained an entry "ExitAddress
 89.248.169.36 2015-08-31 19:04:24". In all but one this entry was empty.
 In one descriptor - the one in the "singles" directory - the preceding
 entry was empty.

 I have now - on my local copy - deleted these empty entries. Now the
 descriptor in "singles" passes as well as 6 of the 9 descriptors in
 directory "tordnsel". I assume the remaining 3 have more empty entries.

 Thanks for spotting this!

 But still this is a bug, right? The converter is not supposed to just give
 up silently on a whole descriptot file just because it encounters an empty
 entry. Btw: it's not a "double" entry as you say. It's an empty entry,
 followed by the next, non-empty, entry. So it's 2 ExitAddress lines
 following each other immediatly, but with different content.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17701#comment:15>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online