[tor-bugs] #17686 [Tor]: Make our openssl-RNG calling code less scary.

[Tor Bug Tracker & Wiki]

#17686: Make our openssl-RNG calling code less scary.
------------------------+------------------------------------
 Reporter:  nickm       |          Owner:
     Type:  defect      |         Status:  needs_review
 Priority:  Medium      |      Milestone:  Tor: 0.2.7.x-final
Component:  Tor         |        Version:
 Severity:  Normal      |     Resolution:
 Keywords:  rng crypto  |  Actual Points:
Parent ID:  #17694      |         Points:
  Sponsor:              |
------------------------+------------------------------------

Comment (by teor):

 Replying to [comment:9 cypherpunks]:
 > Compilation started failing after the merge because of a mismatch
 between the type signature of `crypto_rand` and a mock function. The
 attached patch fixes the issue.

 This unit test used to return failure from the mocked crypto_rand. But the
 real crypto_rand never returned failure. It's probably not an issue, but
 we should check that the unit test still tests what we expect it to test.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17686#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online