[tor-bugs] #16940 [Tor Browser]: Implement loading (only) local change notes after a Tor Browser update

[Tor Bug Tracker & Wiki]

#16940: Implement loading (only) local change notes after a Tor Browser update
--------------------------------------------+------------------------------
 Reporter:  gk                              |          Owner:  tbb-team
     Type:  enhancement                     |         Status:  needs_review
 Priority:  Medium                          |      Milestone:
Component:  Tor Browser                     |        Version:
 Severity:  Normal                          |     Resolution:
 Keywords:  tbb-5.5, TorBrowserTeam201511R  |  Actual Points:
Parent ID:                                  |         Points:
  Sponsor:                                  |
--------------------------------------------+------------------------------

Comment (by gk):

 Replying to [comment:7 mcs]:
 > Replying to [comment:5 gk]:
 > > I wonder whether having `linkPrefix` and `linkLabel` that way is
 causing trouble for translators. My gut tells me "yes". The languages I am
 able to speak "no". Hm...
 >
 > I am not sure, but this approach does provide flexibility, assuming the
 localizers are not confused by it. We did something very similar for the
 about:tor page (see  aboutTor.failure3prefix.label, aboutTor.failure3Link,
 and aboutTor.failure3suffix.label within aboutTor.dtd). So far it looks
 like no one has needed to change the suffix (".").

 Okay, sounds like it is working that way, fine with me.

 I've tested the patches on Linux and local change notes are working + the
 code looks good. Nice job! Just two things occurred to me while
 testing/reading the code:

 1) Should we prepend the value for `startup.homepage_override_url` with
 `about:tbupdate?` as well?
 2) I wonder if we should update the comment above this preference to
 explain what is going on as we don't do this anywhere as far as I can see.
 And using `openURL` gives the wrong impression as we won't open the one
 mentioned there usually. Thus, folks might be confused. If not there, were
 else could mention the "hijacking" of the `openURL` parameter?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16940#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online