[tor-bugs] #17684 [Tor]: Simplify directory_get_from_dirserver so it can be unit tested

[Tor Bug Tracker & Wiki]

#17684: Simplify directory_get_from_dirserver so it can be unit tested
-----------------------------+--------------------------------
     Reporter:  teor         |      Owner:
         Type:  enhancement  |     Status:  new
     Priority:  Medium       |  Milestone:  Tor: 0.2.8.x-final
    Component:  Tor          |    Version:
     Severity:  Normal       |   Keywords:
Actual Points:               |  Parent ID:
       Points:  small        |    Sponsor:
-----------------------------+--------------------------------
 In #4483, I refactor directory_get_from_dirserver so it can be unit
 tested.

 But there's a series of stubborn nested conditionals in the middle of the
 function, that also change the values they're checking.

 If we simplified this knot of conditions, then it would be much easier to
 unit test.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17684>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online