[tor-bugs] #17027 [Tor]: policies_parse_exit_policy_internal should block all IPv4 and IPv6 local addresses

[Tor Bug Tracker & Wiki]

#17027: policies_parse_exit_policy_internal should block all IPv4 and IPv6 local
addresses
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:
     Type:  defect                               |         Status:
 Priority:  High                                 |  needs_review
Component:  Tor                                  |      Milestone:  Tor:
 Severity:  Normal                               |  0.2.6.x-final
 Keywords:  TorCoreTeam201511, security,         |        Version:  Tor:
  026-backport, 027-backport                     |  unspecified
Parent ID:                                       |     Resolution:
  Sponsor:                                       |  Actual Points:
                                                 |         Points:
-------------------------------------------------+-------------------------

Comment (by teor):

 Replying to [comment:27 nickm]:
 > hmm.  I just went to try to squash and merge this to master, but the
 fixup commits aren't in the standard form and I can't figure out how to
 squash them the way that you intended.  The commits they refer to no
 longer exist with those identifiers.  Can you give me a quick squasher's
 guide on this?

 Yes, you're right, the fixups are messy because I refactored the argument
 lists last based on changes in earlier commits.

 Please see bug17027-reject-private-027-v6 based on maint-0.2.7.

 I squashed the fixups, but left the refactoring and documentation
 separate. Please feel free to squash further.

 > I think this is also viable for a 0.2.7 merge once it's seen more
 testing in master.

 I agree.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17027#comment:28>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online