[tor-bugs] #16702 [Tor]: Broken INTRODUCE2 cell on an intro circ bothers Tor

[Tor Bug Tracker & Wiki]

#16702: Broken INTRODUCE2 cell on an intro circ bothers Tor
----------------------+------------------------------------
 Reporter:  s7r       |          Owner:
     Type:  defect    |         Status:  new
 Priority:  Medium    |      Milestone:  Tor: 0.2.8.x-final
Component:  Tor       |        Version:  Tor: 0.2.7.2-alpha
 Severity:  Normal    |     Resolution:
 Keywords:  tor-hs    |  Actual Points:
Parent ID:            |         Points:  medium
  Sponsor:  SponsorR  |
----------------------+------------------------------------
Changes (by asn):

 * cc: dgoulet (added)
 * severity:   => Normal


Comment:

 OK, so this is the code that prints the log message:

 {{{
   intro_point = find_intro_point(circuit);
   if (intro_point == NULL) {
     intro_point = find_expiring_intro_point(service, circuit);
     if (intro_point == NULL) {
       log_warn(LD_BUG,
                "Internal error: Got an INTRODUCE2 cell on an "
                "intro circ (for service %s) with no corresponding "
                "rend_intro_point_t.",
                escaped(serviceid));
       goto err;
     }
   }
 }}}

 I'm wondering what's the functional difference between
 `find_intro_point()` and `find_expiring_intro_point()`. They seem almost
 the same currently.

 Maybe we should be using `service->expiring_nodes` in the latter function?
 Could this be causing the bug?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16702#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online