[tor-bugs] #17568 [Tor Browser]: Clean up tor-control-port.js in Torbutton

Tor Bug Tracker & Wiki blackhole at torproject.org
Wed Nov 18 14:56:40 UTC 2015


#17568: Clean up tor-control-port.js in Torbutton
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:  tbb-
     Type:  task                                 |  team
 Priority:  Medium                               |         Status:
Component:  Tor Browser                          |  needs_revision
 Severity:  Normal                               |      Milestone:
 Keywords:  tbb-torbutton,                       |        Version:
  TorBrowserTeam201511R                          |     Resolution:
Parent ID:                                       |  Actual Points:
  Sponsor:                                       |         Points:
-------------------------------------------------+-------------------------

Comment (by gk):

 Replying to [comment:13 gk]:
 > It seems to me we don't need `"m" : data => utils.listMapData(data, [])`
 as this is only available in the votes.

 Hmm... this is confusing. What consensus type are we using here? I'd
 assume a microdescriptor-based one but the log output I get does not
 convince me, see e.g.
 {{{
 r madiba yG0vPe/ih6Duso1Ih68U41wXJzM Xsg83S1uvP1CQFkzWAhtUFUpkPw
 2015-11-17 22:46:34 209.222.8.196 443 80
 }}}
 If we don't do that, why not, given that we have it cached lying around?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17568#comment:14>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list