[tor-bugs] #13737 [Tor]: Implement circuit building crypto to worker

[Tor Bug Tracker & Wiki]

#13737: Implement circuit building crypto to worker
-------------------------------------------------+-------------------------
 Reporter:  dgoulet                              |          Owner:
     Type:  enhancement                          |         Status:
 Priority:  Medium                               |  needs_review
Component:  Tor                                  |      Milestone:  Tor:
 Severity:  Normal                               |  0.2.???
 Keywords:  tor-client, tor-hs, multicore,       |        Version:  Tor:
  performance, 027-triaged-1-in                  |  0.2.7
Parent ID:                                       |     Resolution:
  Sponsor:                                       |  Actual Points:
                                                 |         Points:  small-
                                                 |  remaning
-------------------------------------------------+-------------------------

Comment (by teor):

 I have reviewed the code: it makes sense to me and I don't see any issues:
 * There is some code duplication between the client and server onionskins,
 but I think that's ok.
 * The starvation-avoidance mechanism in queue_pending_tasks works as
 described. I wonder if we will want to favour server, client, or the
 longer queue in future.

 Someone who is more familiar with cpuworkers or circuit crypto could give
 a more thorough review than I can.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/13737#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online