[tor-bugs] #17572 [Tor]: router_get_fallback_dirserver_by_digest uses authorities, should use fallbacks

[Tor Bug Tracker & Wiki]

#17572: router_get_fallback_dirserver_by_digest uses authorities, should use
fallbacks
------------------------+--------------------------------
     Reporter:  teor    |      Owner:
         Type:  defect  |     Status:  new
     Priority:  Medium  |  Milestone:  Tor: 0.2.8.x-final
    Component:  Tor     |    Version:  Tor: 0.2.4.7-alpha
     Severity:  Normal  |   Keywords:
Actual Points:          |  Parent ID:  #15775
       Points:          |    Sponsor:
------------------------+--------------------------------
 router_get_fallback_dirserver_by_digest looks like it was copied from
 router_get_trusteddirserver_by_digest. The comment was changed, but the
 set of servers searched was not.

 router_get_fallback_dirserver_by_digest is only used in
 connection_dir_client_reached_eof to record 503 "too busy" messages. The
 impact of this issue is that only authorities are getting marked as "too
 busy". Unless a user specifies their own fallbacks, and those fallbacks
 are busy, they'll never see this issue.

 Bug in 5c51b3f1f0d4c394392, released in 0.2.4.7-alpha.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17572>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online