[tor-bugs] #9659 [Tor Browser]: Optimistic Data SOCKS variant (patch for #3875) leads to loop on HTTP requests if no SOCKS response yet

[Tor Bug Tracker & Wiki]

#9659: Optimistic Data SOCKS variant (patch for #3875) leads to loop on HTTP
requests if no SOCKS response yet
-------------------------------------------------+-------------------------
 Reporter:  cypherpunks                          |          Owner:  tbb-
     Type:  defect                               |  team
 Priority:  Medium                               |         Status:
Component:  Tor Browser                          |  needs_review
 Severity:  Normal                               |      Milestone:
 Keywords:  tbb-usability, tbb-crash-hang, tbb-  |        Version:
  firefox-patch, GeorgKoppen201511R,             |     Resolution:
  TorBrowserTeam201511R                          |  Actual Points:
Parent ID:                                       |         Points:
  Sponsor:                                       |
-------------------------------------------------+-------------------------

Comment (by cypherpunks):

 Replying to [comment:29 mcs]:
 > It would be good to have another review:

 It still need to handle case of partial socks answer to be generally
 complete, else code re-starts writing.
 {{{
             //
             // If the connect is still not ready, then continue polling...
             //
             if ((PR_WOULD_BLOCK_ERROR == code) || (PR_IN_PROGRESS_ERROR ==
 code)) {
                 // Set up the select flags for connect...
                 mPollFlags = (PR_POLL_EXCEPT | PR_POLL_WRITE);
                 // Update poll timeout in case it was changed
                 mPollTimeout = mTimeouts[TIMEOUT_CONNECT];
             }
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/9659#comment:31>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online