[tor-bugs] #12538 [Tor]: Make all relays automatically be dir caches

[Tor Bug Tracker & Wiki]

#12538: Make all relays automatically be dir caches
-------------------------------------------------+-------------------------
 Reporter:  cypherpunks                          |          Owner:
     Type:  task                                 |         Status:
 Priority:  High                                 |  needs_review
Component:  Tor                                  |      Milestone:  Tor:
 Severity:  Normal                               |  0.2.8.x-final
 Keywords:  tor-guard, tor-relay, prop237,       |        Version:  Tor:
  026-triaged-1, sebastian-review,               |  unspecified
  027-triaged-1-out, 028-triage, 028-triaged,    |     Resolution:
  mike-can, pre028-patch                         |  Actual Points:
Parent ID:                                       |         Points:
  Sponsor:                                       |  medium/large
-------------------------------------------------+-------------------------

Comment (by nickm):

 Reviewing feature_12538_rebased_6.  The '''CHECK''' notes below are for
 me. :)


 `fa54b983901c396911d8e0732a7cf1ba8135443a  Authorities must set a router's
 V2Dir flag if it supports tunnelled reqs`
    * Looks okay.

 `05f95c8ec50b81ff6e7a7b3cc09f51971fd4f14d  A relay now advertises
 "tunnelled-dir-server" in its descriptor`
    * The new warning in `directory_initiate_command_rend()` should be
 LD_BUG.
    * '''CHECK''': There should be no more instances of DirPort_set!  Grep,
 just in case.
    * I worry about the definition of dir_server_mode().  Possibly, if we
 have advertised that we're a dirserver, we should actually be a dirserver?
    * The check for dir_server_mode(options) in router_dump_to_string() is
 wrong: we should be looking at `router->supports_tunneled_dir_requests`,
 not at our configuration.  We should set that field based on our actual
 settings in `router_build_fresh_descriptor()`.
    * Are we making sure to download information and be a directory cache
 whenever dir_server_mode() is true?

 `d4c08da145564a03ffca9ef234808342613eb2d8  Client should check if dir
 server has open dir port or handles tunnelled requests`
    * Looks okay.
 `91d1600328f4f6d9a0c3dcb5ab3558e23af891b4  Add unit test for
 router_pick_directory_server_impl`
    * Looks okay.


 `90f2cfb81a383481cdf6e31d623c564840de7133  Add new DirCache configuration
 option`
    * Looks okay.

 `be7d522274d21db2bb6bbc8d422fa35b59a4da12  Add NotDir status flag and dir-
 cache server entry`
    * '''CHECK''': re-read the thread above; why are we doing this? Not
 sure it's an improvement.

 `763d03da5a87727fc44a1369650694ec91197619  Add the BelieveNotDir consensus
 parameter`
    * '''CHECK''': re-read the thread above; why are we doing this? Not
 sure it's an improvement.

 `8a9ac52a9e41ba2db3d7045124f7c055ced85721  Fix wide line in or.h`
 `b1efeb2c693042c7a7a01520e8b713c1cbae0960  Correct widelines in tests`
    * trivially correct

 `02ae35e59c12920e0ba6a8d9c1712d30ca1a7ffa  Rebuild descriptor when
 DirCache is {dis,en}abled`
 `ae1647fd1565e0ed5718f6d82244b8ea2d80d4ee  {dis,en}abling DirCache is a
 semantic change`
    * Yup.

 `a832b7e12cb553dd49b69817ac7d534a6dc8aa07  A router must be a dir cache
 before it may be HSDir`
    * Yup.
 `5f294acfcfe5915dc1d040e3f431446e9c862d90  Let make_consensus_method_list
 be used in tests`
    * looks ok.
 `239be79713ac388861728bc1a09f815bf348eddd  Automatically generate md-con
 method vers in test`
    * Memory leak here?
 `8cd810633a8cf8a911bc652c6d405608c04bfe58  Assert rs are added in con and
 con_md tests`
    * Looks ok.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/12538#comment:64>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online