[tor-bugs] #16014 [Tor Browser]: Windows: staged update fails if Meek is enabled

[Tor Bug Tracker & Wiki]

#16014: Windows: staged update fails if Meek is enabled
-------------------------+-------------------------------------------------
     Reporter:  mcs      |      Owner:  tbb-team
         Type:  defect   |     Status:  needs_review
     Priority:  normal   |  Milestone:
    Component:  Tor      |    Version:
  Browser                |   Keywords:  TorBrowserTeam201505R,
   Resolution:           |  GeorgKoppen201505R
Actual Points:           |  Parent ID:
       Points:           |
-------------------------+-------------------------------------------------
Changes (by gk):

 * status:  needs_information => needs_review


Comment:

 Replying to [comment:10 mcs]:
 > Replying to [comment:9 gk]:
 > > Yeah, I just made a nightly build forgetting about the different
 certs, good. While the updated/ directory is gone there is now the problem
 that every start produces the check-your-extensions-compatibility-dialog
 which is quite annoying. This does not happen without using your
 updater.exe and we should avoid that.
 >
 > I do not see how the fix for this ticket could affect the extensions
 compatibility dialog.  How can I reproduce that problem?  Is it a dialog
 that stays open or is it the one that quickly opens and closes while
 checking for extension updates?

 The latter. The weird thing is that I see it once on the Windows machine
 doing a "normal" update from 4.5a5 (with or without meek) which is quite
 normal. But using your updater.exe I see that dialog shortly with every
 start. If you think these things are unrelated, fine by me. I am just
 worried that the fix has some unintended side effects. :)

 > > Btw: Do you know where this mysterious `tobedeleted` directory is
 coming from with weird "temporary files" in it (happens without your
 updater.exe as well)? I just saw this inside /Browser after the update
 while testing.
 >
 > Having a few files in "tobedeleted" is expected.  If the updater is
 unable to delete a file on Windows because it is in use, it moves the file
 to a tobedeleted directory and arranges for the file to be deleted the
 next time Windows is restarted.  The file is also renamed to so it has a
 temporary/unique name.  This usually happens for updater.exe and the
 NSPR/NSS DLLs.  While describing this to you, I just realized that this
 involves Windows registry changes.  Should we create our own code to clean
 up the "tobedeleted" files?

 Dunno, I don't feel strongly here.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16014#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online