[tor-bugs] #12498 [Tor]: Implement ed25519 identity keys (prop 220)

[Tor Bug Tracker & Wiki]

#12498: Implement ed25519 identity keys (prop 220)
-------------------------+-------------------------------------------------
     Reporter:  asn      |      Owner:  nickm
         Type:  task     |     Status:  needs_review
     Priority:  major    |  Milestone:  Tor: 0.2.7.x-final
    Component:  Tor      |    Version:  Tor: 0.2.7
   Resolution:           |   Keywords:  026-triaged-1, 027-triaged-1-in,
Actual Points:           |  SponsorU
       Points:  large    |  Parent ID:  #15054
-------------------------+-------------------------------------------------

Comment (by asn):

 Hello, here is a small code review of the current `12498_ed25519_keys_v5`
 branch up to `b52da5b`. I might get to the rest of the branch but not sure
 if it's going to happen RSN.

 - I think there is a memleak when parsing identity lines on
 microdescriptors. The code seems to allow multiple such identity lines,
 but then for each one we do

 {{{
 md->ed25519_identity_pkey = tor_memdup(&k, sizeof(k));
 }}}
   without first cleaning the previously memdup'ed memory. Why would
 multiple `id ed25519` lines be allowed?

 - I'm not sure what this 'tag' thing is on `ed_key_init_from_file()`. I
 don't see it explained anywhere.

 - `ed25519_cert_encoded_len()` can return -1 but it's retval is never
 checked. I think that's OK because all its input is generated by us, but
 might as well mention it here.

 - Comment typo "not just and" at:
 {{{
 /** Helper for tor_cert_create(): signs any 32 bytes, not just and ed25519
  * key.
  */
 static tor_cert_t *
 tor_cert_sign_impl(const ed25519_keypair_t *signing_key,
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/12498#comment:26>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online