[tor-bugs] #16220 [Tor Browser]: Torbutton/Torlauncher flips out if TOR_SKIP_LAUCH is set without TOR_SOCKS_PORT

[Tor Bug Tracker & Wiki]

#16220: Torbutton/Torlauncher flips out if TOR_SKIP_LAUCH is set without
TOR_SOCKS_PORT
-----------------------------+----------------------
     Reporter:  yawning      |      Owner:  tbb-team
         Type:  defect       |     Status:  new
     Priority:  normal       |  Milestone:
    Component:  Tor Browser  |    Version:
   Resolution:               |   Keywords:
Actual Points:               |  Parent ID:
       Points:               |
-----------------------------+----------------------

Comment (by yawning):

 A ha, I see what's happening but I'm not sure if it's correct.

 {{{
 mcs | The comparison is the address and port that was logged
     | vs. the values of these prefs:  network.proxy.socks and
     | network.proxy.socks_port
 }}}

 Since I usually have `TOR_SOCKS_PORT=9050` as part of my environment, it's
 saved in my profile's config.  I'm not sure something that's set as an env
 var should be persisted (as in, I'd expect the value displayed in
 `about:config` to reset back to the default if I unset the env var and
 relaunch Tor Browser).

 If I go into `about:config` and reset `network.proxy.socks_port`,
 everything works as expected, till I launch Tor Browser with a custom port
 again (and it gets saved).

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16220#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online