[tor-bugs] #16151 [metrics-lib]: Add new descriptor source to fetch descriptors from CollecTor via https

[Tor Bug Tracker & Wiki]

#16151: Add new descriptor source to fetch descriptors from CollecTor via https
-----------------------------+--------------------------
     Reporter:  karsten      |      Owner:  karsten
         Type:  enhancement  |     Status:  needs_review
     Priority:  normal       |  Milestone:
    Component:  metrics-lib  |    Version:
   Resolution:               |   Keywords:
Actual Points:               |  Parent ID:
       Points:               |
-----------------------------+--------------------------

Comment (by karsten):

 Replying to [comment:9 iwakeh]:
 > The changes to the "remoteDirectories" array cannot be inferred from the
 interface-contract and could cause unwanted side effects for the caller of
 "collectRemoteFiles".

 Oh, good point, didn't think about that.  Fixed.

 > What should happen if the same file is listed twice?

 That would be a bug in the input data.  The current behavior is that the
 last entry wins.  I wrote a test case for this.

 > And, a missmatch between directory date and file date?

 We only look at the link in `<a href="...">`, not at the displayed
 filename.  If the two differ, that's also a bug in the input data and
 nothing we should worry about.

 Okay, sounds like we agree on the interface.  Will merge tomorrow.  Happy
 to add more tests later.  Thanks again for your reviews!  Very helpful!

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16151#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online