[tor-bugs] #12498 [Tor]: Implement ed25519 identity keys (prop 220)

[Tor Bug Tracker & Wiki]

#12498: Implement ed25519 identity keys (prop 220)
-------------------------+-------------------------------------------------
     Reporter:  asn      |      Owner:  nickm
         Type:  task     |     Status:  needs_review
     Priority:  major    |  Milestone:  Tor: 0.2.7.x-final
    Component:  Tor      |    Version:  Tor: 0.2.7
   Resolution:           |   Keywords:  026-triaged-1, 027-triaged-1-in,
Actual Points:           |  SponsorU
       Points:  large    |  Parent ID:  #15054
-------------------------+-------------------------------------------------

Comment (by dgoulet):

 Continuing review from yesterday:

 * 4d2c3ba3c86a8754842ea11f7371981d2264395a

  lgtm

 * c98b6874cf00491ff40b1470619aaab9059e9e33

  lgtm

 * 3b1e0e2374225ab483ccd632741ffe1f618a7b87

  lgtm

 * 54eb95a777dd585112e3f0af4d32e7f6dbacb88d

  lgtm

 * 4198cba16944d7f9172e850de12285e3995f7e1b
 * d89b55a047206f636d7a3fd0cb058b72a53d02bd
 * 931901b09f97136a9456bfdcc14f5a13849e5fa7
 * 46c53edbe0ca7ff3e93fad16a960b28e56ada5bb
 * 2b87b52c88008bff97b58e69b8567ab57fdb379e

  Fixes and patch lgtm.

 * b3ed7ffa5e8f633b7bd586e669571b5a83cfcef9
 * e8708077fc9390aa4e8c6465e5b1e1c4d17a2255
 * 91bd035e21395edc11c692457bfd2c9034e09cde

  lgtm

 * d99a84307a7dd2248536b751c65dea8cc51222cc
 * 660fff9e5b6cde9c43c87335c1e2661455b90317
  - I don't see any manual page entry for these option. On purpose maybe?
 {{{
 +  V(SigningKeyLifetime,              INTERVAL, "30 days"),
 +  V(TestingLinkKeyLifetime,          INTERVAL, "2 days"),
 +  V(TestingAuthKeyLifetime,          INTERVAL, "2 days"),
 +  V(TestingLinkKeySlop,              INTERVAL, "3 hours"),
 +  V(TestingAuthKeySlop,              INTERVAL, "3 hours"),
 +  V(TestingSigningKeySlop,           INTERVAL, "1 day"),
 }}}
  - config.c: Typo in REJECT message, missing "Testing":
 {{{
 +  if (options->TestingLinkKeyLifetime < options->TestingAuthKeySlop*2)
 +    REJECT("LinkKeyLifetime is too short.");
 +  if (options->TestingAuthKeyLifetime < options->TestingLinkKeySlop*2)
 +    REJECT("AuthKeyLifetime is too short.");
 }}}

  lgtm

 * 9641ea395b93ba444e9ab508ff4697ac34d0fed3
 * 66772a26d8d4c662b41b7522075771c8697006b9
  - router.c: My guess here is that is a forgotten artefact? :)
 {{{
  assert_identity_keys_ok(void)
  {
 +  if (1)
 +    return;
 }}}

  lgtm

 * ba911b29410c6b8f874beedaec072a10e2038da9

  trivial fix. lgtm

 * 09fa94086aa1793a0f24fc81f4c9b49f66ba6c9f

  lgtm


 Final note, I reviewed the code correctness and what I could find in the
 proposals but keep in mind I'm not in a position to fully review the
 design nor comment on it. This is really a tor subsystem I am quite
 unfamiliar with :S.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/12498#comment:24>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online