[tor-bugs] #8243 [Tor]: Getting the HSDir flag should require more effort

[Tor Bug Tracker & Wiki]

#8243: Getting the HSDir flag should require more effort
-------------------------+-------------------------------------------------
     Reporter:  arma     |      Owner:
         Type:           |     Status:  needs_review
  enhancement            |  Milestone:  Tor: 0.2.7.x-final
     Priority:  major    |    Version:  Tor: 0.2.7
    Component:  Tor      |   Keywords:  SponsorR, tor-auth, needs-proposal,
   Resolution:           |  026-triaged-1, 027-triaged-1-in, SponsorU,
Actual Points:           |  026-backport
       Points:  medium   |  Parent ID:
-------------------------+-------------------------------------------------

Comment (by dgoulet):

 Replying to [comment:25 nickm]:
 > I think looking at node->is_stable might be incorrect. That makes us
 look at the node's stability value form the _last_ consensus, right?  (Or
 did we just go through all the node_t objects and set that?)

 It's set in `set_routerstatus_from_routerinfo()` which set both the
 `routerstatus_t` and `node_t` variable `is_stable` at the same time.

 Few line after, `dirserv_thinks_router_is_hs_dir()` is called so it seems
 that using `node->is_stable` in that function will give us the latest
 status we have on that relay.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/8243#comment:26>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online