[tor-bugs] #13483 [Tor]: rend_consider_services_upload() sets initial next_upload_time which is clobbered when first intro point established?

[Tor Bug Tracker & Wiki]

#13483: rend_consider_services_upload() sets initial next_upload_time which is
clobbered when first intro point established?
------------------------+--------------------------------
     Reporter:  arma    |      Owner:  dgoulet
         Type:  defect  |     Status:  accepted
     Priority:  normal  |  Milestone:  Tor: 0.2.7.x-final
    Component:  Tor     |    Version:
   Resolution:          |   Keywords:  SponsorR, tor-hs
Actual Points:          |  Parent ID:
       Points:          |
------------------------+--------------------------------

Comment (by dgoulet):

 After some thinking and research, thanks to special's help, here is what
 we think we should do.

 The HS descriptor should be uploaded when *all* introduction points have
 been established. Else, the HS ends up uploading a descriptor that may
 contain intro points that are not yet "valid" meaning not yet established
 or proven to work. It could also trigger three uploads for the *same*
 descriptor if every intro points takes more than 30 seconds to establish
 because of desc_is_dirty being set at each intro established.

 The HS will recover from that and upload a new one soon after when
 everything is established but that could be few minutes after.

 Nothing critical but the point is to avoid jungling around and doing
 unnecessary uploads. With this, `MIN_REND_INITIAL_POST_DELAY` will be
 useless (and also especially with #12500 with something like
 `endInitialPostPeriod`)

 If that makes sense, I'll propose a patch for it.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/13483#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online