[tor-bugs] #14429 [Tor Browser]: Automated rounding of content window dimensions

[Tor Bug Tracker & Wiki]

#14429: Automated rounding of content window dimensions
-------------------------+-------------------------------------------------
     Reporter:           |      Owner:  arthuredelstein
  arthuredelstein        |     Status:  needs_revision
         Type:  defect   |  Milestone:
     Priority:  normal   |    Version:
    Component:  Tor      |   Keywords:  tbb-fingerprinting-resolution, tbb-
  Browser                |  torbutton, tbb-4.5-alpha,
   Resolution:           |  TorBrowserTeam201503R, GeorgKoppen201503R
Actual Points:           |  Parent ID:
       Points:           |
-------------------------+-------------------------------------------------
Changes (by gk):

 * status:  needs_review => needs_revision


Comment:

 Here are new testing results:

 1) If you enter fullscreen mode and reload the page the window height is
 not rounded anymore (I get this on Linux OSX and Windows; basically the
 height is always off by one)

 2) On Ubuntu with Unity if I move the browser window out of the screen I
 get to a point where the window gets resized if I am just dropping it. If
 I do that I get a quite small window (which is okay) that has always the
 same size even if I try to maximize it again (which is not okay); while I
 have a similar functionality on Windows I don't have that problem there.

 3) Setting DPI to 150% and maximizing on Windows leaves me with 900 x 450
 (fullscreen stays the same after reloading).

 4) Setting DPI to 125% and maximizing on Windows leaves me with 1250 x 500
 (fullscreen is 1250 x 625 after reloading).

 5) If I make the menu bar visible with DPI 125% on Windows, the height
 gets off by 1.

 6) I did not test the zoom behavior extensively. But just shrinking the
 window with every zoom step (regardless whether the text gets smaller or
 larger) seems strange to me. If you zoom a couple of times there is almost
 no window left. I think we should think a bit harder about that case,
 preferably in a different ticket.

 Wrt the #7255 patch: I think you can just revert it and implement a hint
 for the user that explains what happened after the resize (as we discussed
 in #7255). Having the fix for #7255 with the patch for this ticket makes
 not much sense.

 Needs_revision is mainly for the latter. I think we could ship the patch
 in the next alpha (maybe modulo the zoom part). I am interested in getting
 feedback from other setups.

 I am starting with the code review now.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/14429#comment:40>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online