[tor-bugs] #13670 [Tor Browser]: ensure OCSP & favicons respect URL bar domain isolation

[Tor Bug Tracker & Wiki]

#13670: ensure OCSP & favicons respect URL bar domain isolation
-------------------------+-------------------------------------------------
     Reporter:           |      Owner:  arthuredelstein
  arthuredelstein        |     Status:  needs_revision
         Type:  defect   |  Milestone:
     Priority:  normal   |    Version:
    Component:  Tor      |   Keywords:  tbb-4.5-alpha,
  Browser                |  TorBrowserTeam201503R
   Resolution:           |  Parent ID:
Actual Points:           |
       Points:           |
-------------------------+-------------------------------------------------

Comment (by arthuredelstein):

 Replying to [comment:20 gk]:
 > Replying to [comment:18 arthuredelstein]:
 > > Replying to [comment:17 gk]:
 > > > Let's see how it goes if I add the missing `aIsolationKey`.
 > >
 > > Sorry -- I seem to have failed to re-push that fix. It should be
 correct now.
 >
 > That one fixes it but the build is still failing on Linux systems (have
 not tested the other ones yet):
 > {{{
 > pkix_pl_ocspresponse.c: In function 'pkix_pl_OcspResponse_Create':
 > pkix_pl_ocspresponse.c:493:30: warning: passing argument 5 of
 'hcv1->createFcn' makes pointer from integer without a cast
 >                          rv = (*hcv1->createFcn)(serverSession, "http",
 >                               ^
 > pkix_pl_ocspresponse.c:493:30: note: expected 'const char *' but
 argument is of type 'PRIntervalTime'
 > pkix_pl_ocspresponse.c:493:30: warning: passing argument 6 of
 'hcv1->createFcn' makes integer from pointer without a cast
 > pkix_pl_ocspresponse.c:493:30: note: expected 'PRIntervalTime' but
 argument is of type 'void **'
 > pkix_pl_ocspresponse.c:493:30: error: too few arguments to function
 'hcv1->createFcn'
 > make[9]: *** [/home/ubuntu/build/tor-browser/obj-i686-pc-linux-
 gnu/security/nss/lib/libpkix/pkix_pl_nss/pki/pkix_pl_ocspresponse.o] Error
 1
 > }}}

 I'll work on fixing this. I developed the code on a Mac and had not tested
 linux.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/13670#comment:21>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online