[tor-bugs] #13670 [Tor Browser]: ensure OCSP & favicons respect URL bar domain isolation

[Tor Bug Tracker & Wiki]

#13670: ensure OCSP & favicons respect URL bar domain isolation
-------------------------+-------------------------------------------------
     Reporter:           |      Owner:  arthuredelstein
  arthuredelstein        |     Status:  needs_revision
         Type:  defect   |  Milestone:
     Priority:  normal   |    Version:
    Component:  Tor      |   Keywords:  tbb-4.5-alpha,
  Browser                |  TorBrowserTeam201503R
   Resolution:           |  Parent ID:
Actual Points:           |
       Points:           |
-------------------------+-------------------------------------------------

Comment (by arthuredelstein):

 Replying to [comment:17 gk]:
 > {{{
 > /home/ubuntu/build/tor-browser/security/certverifier/OCSPCache.cpp: In
 member function 'SECStatus mozilla::psm::OCSPCache::Put(const
 CERTCertificate*, const CERTCertificate*, const char*, PRErrorCode,
 PRTime, PRTime)':
 > /home/ubuntu/build/tor-
 browser/security/certverifier/OCSPCache.cpp:205:56: error: no matching
 function for call to 'mozilla::psm::OCSPCache::FindInternal(const
 CERTCertificate*&, const CERTCertificate*&, mozilla::MutexAutoLock&)'
 >    int32_t index = FindInternal(aCert, aIssuerCert, lock);
 >                                                         ^
 > /home/ubuntu/build/tor-
 browser/security/certverifier/OCSPCache.cpp:205:56: note: candidate is:
 > /home/ubuntu/build/tor-
 browser/security/certverifier/OCSPCache.cpp:117:1: note: int32_t
 mozilla::psm::OCSPCache::FindInternal(const CERTCertificate*, const
 CERTCertificate*, const char*, const MutexAutoLock&)
 >  OCSPCache::FindInternal(const CERTCertificate* aCert,
 >  ^
 > /home/ubuntu/build/tor-
 browser/security/certverifier/OCSPCache.cpp:117:1: note:   candidate
 expects 4 arguments, 3 provided
 > make[5]: *** [OCSPCache.o] Error 1
 > }}}
 >
 > Let's see how it goes if I add the missing `aIsolationKey`.

 Sorry -- I seem to have failed to re-push that fix. It should be correct
 now.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/13670#comment:18>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online