[tor-bugs] #15201 [Tor Browser]: Windows: disable "runas" code path in updater

[Tor Bug Tracker & Wiki]

#15201: Windows: disable "runas" code path in updater
-------------------------+-------------------------------------------------
     Reporter:  mcs      |      Owner:  mcs
         Type:  defect   |     Status:  new
     Priority:  normal   |  Milestone:
    Component:  Tor      |    Version:
  Browser                |   Keywords:  firefox-patch, tbb-4.5-alpha,
   Resolution:           |  TorBrowserTeam201503
Actual Points:           |  Parent ID:
       Points:           |
-------------------------+-------------------------------------------------

Comment (by mcs):

 Replying to [comment:2 mikeperry]:
 > Oh crap, I merged brade/bug15201-01 before you set this ticket in
 needs_review. While looking at other branches, I saw the branch and it
 seemed ok to me.
 >
 > Let me know if you discover any issues with it, and we can remove it or
 fix it when we rebase on top of 31.6.0ESR. Otherwise, feel free to just
 close this ticket!

 An aggressive merge, although I do not think the code is harmful. Kathy
 and I were trying to finish it on Friday but ran out of time, and then
 Kathy and I were both afk this entire weekend. When we tested a Windows
 build that includes the patch, we confirmed that the UAC prompt does not
 appear (good) but no error message was displayed (bad, or at least not
 what we expected). That is why we did not mark it as ready for review. We
 will do some more testing early this week and can fix the error handling
 with a followup patch if necessary. Since it is so difficult for users to
 shoot themselves in the foot in this way (given the standalone nature of
 our Tor Browser install), I do not think reporting an error is crucial.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/15201#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online