[tor-bugs] #13380 [EFF-HTTPS Everywhere]: Add Pale Moon 25 support

[Tor Bug Tracker & Wiki]

#13380: Add Pale Moon 25 support
--------------------------------------+------------------------------
     Reporter:  cypherpunks           |      Owner:  zyan
         Type:  project               |     Status:  new
     Priority:  normal                |  Milestone:  HTTPS-E 4 stable
    Component:  EFF-HTTPS Everywhere  |    Version:
   Resolution:                        |   Keywords:
Actual Points:                        |  Parent ID:
       Points:                        |
--------------------------------------+------------------------------

Comment (by cypherpunks):

 To fix this: edit install.rdf so it adds Pale Moon 25.x's guid. min
 version should be 25.0, max version 25.*. The second file that has to be
 edited is chrome.manifest. Here you have to point it to toolbar_button.xul
 for that guid. This will add the button to the nav toolbar in Pale Moon
 25.x. I tested this on 25.2.1, and it works for 4.0.3. Pale Moon 24.x and
 earlier have the same guid as Firefox. The options window appears to be
 broken if I try this on 5.0dev2. I haven't tried this on dev3 or dev4.
 Hope to see PM25 support in 4.0.4 or 5.0.

 install.rdf:

       <em:targetApplication><!-- Pale Moon 25.x+ -->
          <Description>
             <em:id>{8de7fcbb-c55c-4fbe-bfc5-fc555c87dbc4}</em:id>
             <em:minVersion>25.0</em:minVersion>
             <em:maxVersion>25.*</em:maxVersion>
          </Description>
       </em:targetApplication>

 chrome.manifest:

     # Firefox windows
     overlay chrome://browser/content/browser.xul      chrome://https-
 everywhere/content/toolbar_button.xul application={ec8030f7-c20a-464f-
 9b0e-13a3a9e97384}
     # Pale Moon 25.x+ windows
     overlay chrome://browser/content/browser.xul      chrome://https-
 everywhere/content/toolbar_button.xul application={8de7fcbb-c55c-4fbe-
 bfc5-fc555c87dbc4}

 Not sure if I had to include the Firefox section, but on my fixed version
 I added it anyways. The button appears to have been added to the nav
 toolbar in PM25 using https-everywhere 3.5.3 without any editing. One
 issue I ran into for this 4.0.3 edit version was the checkmark Show
 Counter, where it would be enabled if I unchecked it and vice versa. But I
 don't see that issue anymore.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/13380#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online