[tor-bugs] #12827 [Tor Browser]: Create preference to disable SVG

[Tor Bug Tracker & Wiki]

#12827: Create preference to disable SVG
-------------------------+-------------------------------------------------
     Reporter:           |      Owner:  mcs
  mikeperry              |     Status:  needs_review
         Type:           |  Milestone:
  enhancement            |    Version:
     Priority:  major    |   Keywords:  tbb-security, tbb-isec-report,
    Component:  Tor      |  tbb-4.5-alpha, TorBrowserTeam201503R
  Browser                |  Parent ID:  #9387
   Resolution:           |
Actual Points:           |
       Points:           |
-------------------------+-------------------------------------------------

Comment (by mikeperry):

 Ok, I looked over this for general safety and it seems good to me, so I
 went ahead and merged it in the 4.5 branch. I am not sure it covers all of
 the cases, or how I would even tell that for sure. Did you test things
 like SVG images encoded data URIs, for example?

 I also changed the name of the pref to be svg.in-content.enabled, to be
 consistent with the other existing svg prefs already in about:config. I
 did this in a fixup commit on the 4.5 branch.

 Finally, out of curiosity, do you know why the ImageFactory code has this
 bizarre pattern of returning already_addReffed pointers, while *also*
 calling .forget() before returning anything? I saw your cut+paste of
 BadImage() and was about to get worried, before I realized that it was a
 pre-existing utility function that followed the same pattern as the rest
 of the ImageFactory code...

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/12827#comment:13>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online