[tor-bugs] #6411 [Tor]: Adding hidden services through control socket

[Tor Bug Tracker & Wiki]

#6411: Adding hidden services through control socket
-------------------------+-------------------------------------------------
     Reporter:           |      Owner:  yawning
  kevinevans             |     Status:  needs_review
         Type:           |  Milestone:  Tor: 0.2.7.x-final
  enhancement            |    Version:  Tor: 0.2.3.19-rc
     Priority:  normal   |   Keywords:  hidden-service control maybe-
    Component:  Tor      |  proposal tor-hs globalleaks-wants
   Resolution:           |  Parent ID:  #8993
Actual Points:           |
       Points:           |
-------------------------+-------------------------------------------------
Changes (by yawning):

 * status:  needs_revision => needs_review


Comment:

 Ok, everything except the rend_config_services() code duplication is
 fixed.  Not sure if that's worth doing yet.  The `Port` TARGET bug turned
 out to be something incredibly stupid and simple, so I left the code as
 is, and added a sanity check so the command will return an error instead
 of crash.

 The latest commit in the branch is a bit overloaded since it fixes the
 TARGET sillyness, changes return values of `rend_service_add_ephemeral()`
 (so that -1 is a generic failure), and adds the comments you wanted.
 Sorry.

 Tentatively needs_review-ing this again, so we can argue about
 `rend_config_services()`, and since everything else is addressed.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/6411#comment:47>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online