[tor-bugs] #14937 [Tor Browser]: Get meek working in Tor Circuit Display

[Tor Bug Tracker & Wiki]

#14937: Get meek working in Tor Circuit Display
-------------------------+-------------------------------------------------
     Reporter:           |      Owner:  arthuredelstein
  arthuredelstein        |     Status:  needs_review
         Type:  defect   |  Milestone:
     Priority:  normal   |    Version:
    Component:  Tor      |   Keywords:  tbb-circuit-display, tbb-usability,
  Browser                |  tbb-4.5-alpha, TorBrowserTeam201503R,
   Resolution:           |  GeorgKoppen201503R
Actual Points:           |  Parent ID:
       Points:           |
-------------------------+-------------------------------------------------

Comment (by gk):

 Replying to [comment:18 arthuredelstein]:
 > Here's my current solution for this ticket. It's not ideal, because it
 would be nicer to directly match the meek fingerprint to the entry node in
 the circuit we are examining. But it works, so I would suggest using this
 patch until we include the meek fingerprints in TBB directly.
 >
 >
 https://github.com/arthuredelstein/torbutton/commit/7653f8e44e7800915563b622c4a5ef6931db4d23

 Arthur: Looks good to me. I just have two nits:

 1) `&#x202C;" );` <- superfluous whitespace after the quotation mark
 2) `match(/^\"?(.*?)\"?$|(.*)/)[1];` <- Why are you escaping the quotation
 mark? It is no special RegEx character. Regular expression are already
 complex beasts, could you just omit the backslashes? Unless I am missing
 something here could you change that in `trimQuotes()` as well?

 David: You should we proceed here? Should we take Arthur's patch as a
 stopgap?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/14937#comment:20>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online