[tor-bugs] #12716 [meek]: Make meek-client-torbrowser take the firefox command as a parameter

[Tor Bug Tracker & Wiki]

#12716: Make meek-client-torbrowser take the firefox command as a parameter
------------------------+----------------------------
     Reporter:  dcf     |      Owner:  dcf
         Type:  defect  |     Status:  needs_revision
     Priority:  minor   |  Milestone:
    Component:  meek    |    Version:
   Resolution:          |   Keywords:
Actual Points:          |  Parent ID:
       Points:          |
------------------------+----------------------------

Comment (by infinity0):

 The solution to this ticket, on Windows, forces one more child process
 between meek-client-wrapper and firefox, because windows inherently
 doesn't have "exec" (or something that replaces the current process). So
 that commit is necessary for this new situation to be cleaned up properly,
 because the direct child of the wrapper needs *time* to clean up its own
 children (firefox), and meek-client-wrapper currently doesn't give it this
 time. (Explained in more detail in ticket:15125#comment:3.)

 So, yes you could merge what we have so far, but I think for a "clean
 release" with fewer issues it's better to also merge the fix for 15125. I
 appreciate that it's more complex, which I can help to reduce.

 We can wait for tor-qa to report back the situation on windows, but I'm
 pretty sure I'm accurate in my theorising. I have also tested this stuff
 on a Windows 7 VM myself.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/12716#comment:20>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online