[tor-bugs] #12716 [meek]: Make meek-client-torbrowser take the firefox command as a parameter

[Tor Bug Tracker & Wiki]

#12716: Make meek-client-torbrowser take the firefox command as a parameter
------------------------+----------------------------
     Reporter:  dcf     |      Owner:  dcf
         Type:  defect  |     Status:  needs_revision
     Priority:  minor   |  Milestone:
    Component:  meek    |    Version:
   Resolution:          |   Keywords:
Actual Points:          |  Parent ID:
       Points:          |
------------------------+----------------------------

Comment (by dcf):

 Replying to [comment:15 infinity0]:
 > `readlink -f` should work instead of `realpath`. I've asked tor-qa about
 this.

 `$(dirname "$0")` might work. You don't need a canonical path, just an
 absolute path.

 > The Go options library does not allow "required options" because they
 are an oxymoron - they recommend that required options should instead be a
 positional argument - https://groups.google.com/forum/#!topic/golang-
 nuts/agYvRPNaBNA
 >
 > So I thought a default value of "meek-browser-helper" was the best
 option - it would work at least some of the time (as opposed to none of
 the time), and distros can still install their own /usr/bin/meek-browser-
 helper if they disagreed with the example script given.
 >
 > An alternative is to set the default value to "", and if this is not set
 by the user then give a custom error message like "either set --helper or
 use meek-client directly". Will do that in a commit tomorrow if you
 prefer.

 The last one is what I had in mind—just output an error. Or we could just
 make it really optional, and not run any helper (nor pass --helper to
 meek-client) if it's missing.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/12716#comment:16>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online