[tor-bugs] #9495 [Tor]: Must we still disable threads on *-*-solaris*?

[Tor Bug Tracker & Wiki]

#9495: Must we still disable threads on *-*-solaris*?
-------------------------+-------------------------------------------------
     Reporter:  nickm    |      Owner:
         Type:  defect   |     Status:  reopened
     Priority:  minor    |  Milestone:  Tor: 0.2.6.x-final
    Component:  Tor      |    Version:
   Resolution:           |   Keywords:  tor-relay solaris 026-triaged-1
Actual Points:           |  regression
       Points:           |  Parent ID:
-------------------------+-------------------------------------------------

Comment (by nickm):

 Oh '''man'''.

 I think I have it.

 {{{
 diff --git a/src/common/compat_pthreads.c b/src/common/compat_pthreads.c
 index f4a6cad..984e4c8 100644
 --- a/src/common/compat_pthreads.c
 +++ b/src/common/compat_pthreads.c
 @@ -279,7 +279,7 @@ tor_threads_init(void)
      pthread_mutexattr_init(&attr_recursive);
      pthread_mutexattr_settype(&attr_recursive, PTHREAD_MUTEX_RECURSIVE);
      tor_assert(0==pthread_attr_init(&attr_detached));
 -    tor_assert(0==pthread_attr_setdetachstate(&attr_detached, 1));
 +    tor_assert(0==pthread_attr_setdetachstate(&attr_detached,
 PTHREAD_CREATE_DETACHED));
      threads_initialized = 1;
      set_main_thread();
    }
 }}}

 Now it doesn't crash for me.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/9495#comment:14>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online