[tor-bugs] #15211 [Tor]: Audit all asserts to ensure they don't have side effects

[Tor Bug Tracker & Wiki]

#15211: Audit all asserts to ensure they don't have side effects
-----------------------------+--------------------------------
     Reporter:  cypherpunks  |      Owner:
         Type:  defect       |     Status:  new
     Priority:  normal       |  Milestone:  Tor: 0.2.7.x-final
    Component:  Tor          |    Version:
   Resolution:               |   Keywords:
Actual Points:               |  Parent ID:
       Points:               |
-----------------------------+--------------------------------

Comment (by cypherpunks):

 A quick grep for `tor_assert(.*(` and manual parsing turned up with
 {{{
 src/common/compat_pthreads.c:281:
 tor_assert(0==pthread_attr_init(&attr_detached));
 src/common/compat_pthreads.c:282:
 tor_assert(0==pthread_attr_setdetachstate(&attr_detached, 1));
 src/or/rendservice.c:3323:
 tor_assert(!crypto_pk_generate_key(intro->intro_key));
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/15211#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online