[tor-bugs] #15085 [Tor Browser]: about:tor page has text alignment problems for RTL languages

[Tor Bug Tracker & Wiki]

#15085: about:tor page has text alignment problems for RTL languages
---------------------------------+-----------------------------------
     Reporter:  arthuredelstein  |      Owner:  arthuredelstein
         Type:  defect           |     Status:  needs_review
     Priority:  normal           |  Milestone:
    Component:  Tor Browser      |    Version:
   Resolution:                   |   Keywords:  TorBrowserTeam201503R
Actual Points:                   |  Parent ID:
       Points:                   |
---------------------------------+-----------------------------------

Comment (by arthuredelstein):

 Replying to [comment:6 brade]:
 > Replying to [comment:4 arthuredelstein]:
 > > Here's my patch:
 > >
 https://github.com/arthuredelstein/torbutton/commit/a72597317e43b6fac8b8851f948f147a2f17788e

 Thanks for the quick review!

 > Why were the parentheses removed from 501(c)(3)?  It seems like they
 should be there as that is how to correctly specify 501(c)(3).

 I was having trouble getting the parentheses to look right, but I've now
 got it working.

 > For my own understanding, is it better to have CSS rules for both LTR
 and RTL?  I always thought it was better (faster layout) to have a general
 rule for one and then a more specific rule for the other.  If we are going
 to have two specific rules, we should get rid of the general rule for
 #middle ul.

 Good point -- fixed. Here's the new version of the patch:
 https://github.com/arthuredelstein/torbutton/commit/6e3618eb69f7665664dfe536abff3eea676ec422

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/15085#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online