[tor-bugs] #4862 [Tor]: Consider disabling dynamic intro point formula (numerology)

[Tor Bug Tracker & Wiki]

#4862: Consider disabling dynamic intro point formula (numerology)
-------------------------+-------------------------------------------------
     Reporter:  hellais  |      Owner:
         Type:           |     Status:  needs_review
  enhancement            |  Milestone:  Tor: 0.2.7.x-final
     Priority:  major    |    Version:  Tor: 0.2.7
    Component:  Tor      |   Keywords:  needs-proposal, tor-hs,
   Resolution:           |  027-triaged-1-in, SponsorR
Actual Points:           |  Parent ID:
       Points:           |
  medium/large           |
-------------------------+-------------------------------------------------
Changes (by dgoulet):

 * status:  needs_revision => needs_review


Comment:

 Replying to [comment:41 asn]:
 > Two very minor things:
 >
 > - Maybe we should change the following log message:
 >   {{{
 >       log_info(LD_REND, "Giving up on %s as intro point for %s"
 >                " (circuit disappeared).",
 >
 safe_str_client(extend_info_describe(intro->extend_info)),
 >                safe_str_client(service->service_id));
 >   }}}
 >   since now we attempt a retry instead of giving up on the circuit.
 >
 > - There is this comment that is also not quite true anymore:
 >   {{{
 >         /* This funcion will be called again by the main loop so this
 intro
 >          * point without a intro circuit will be removed. */
 >   }}}

 Good catch. I fixed both hopefully correctly. See top commit of the new
 branch. For comment:40, #16260 has been merged so we won't end up changing
 the IP.

 See branch: `bug4862_027_04`

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/4862#comment:42>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online