[tor-bugs] #16449 [Tor]: Segmentation fault on key generation

[Tor Bug Tracker & Wiki]

#16449: Segmentation fault on key generation
-----------------------------+------------------------------
     Reporter:  cypherpunks  |      Owner:
         Type:  defect       |     Status:  needs_review
     Priority:  normal       |  Milestone:
    Component:  Tor          |    Version:  Tor: unspecified
   Resolution:               |   Keywords:
Actual Points:               |  Parent ID:
       Points:               |
-----------------------------+------------------------------
Changes (by cypherpunks):

 * status:  new => needs_review


Comment:

 {{{
 diff --git a/src/or/routerkeys.c b/src/or/routerkeys.c
 index 2fd7f41..d075c67 100644
 --- a/src/or/routerkeys.c
 +++ b/src/or/routerkeys.c
 @@ -63,7 +63,7 @@ read_encrypted_secret_key(ed25519_secret_key_t *out,
    r = 1;

   done:
 -  memwipe(encrypted_key, 0, encrypted_len);
 +  memwipe(encrypted_key, 0, sizeof(encrypted_key));
    memwipe(pwbuf, 0, sizeof(pwbuf));
    tor_free(tag);
    if (secret) {
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16449#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online