[tor-bugs] #16389 [Tor]: Redesign the HS client descriptor cache

[Tor Bug Tracker & Wiki]

#16389: Redesign the HS client descriptor cache
-------------------------+--------------------------------
     Reporter:  dgoulet  |      Owner:
         Type:  defect   |     Status:  needs_review
     Priority:  major    |  Milestone:  Tor: 0.2.7.x-final
    Component:  Tor      |    Version:
   Resolution:           |   Keywords:  SponsorR, tor-hs
Actual Points:           |  Parent ID:  #16381
       Points:           |
-------------------------+--------------------------------
Changes (by dgoulet):

 * status:  needs_revision => needs_review


Comment:

 Replying to [comment:7 nickm]:
 > Replying to [comment:6 dgoulet]:
 > > Replying to [comment:5 nickm]:
 > > > Suggestions:
 [snip]
 > > >   * Does the new "goto_err" in rend_cache_store_v2_desc_as_client()
 correctly make us close all the pending connections?
 > >
 > > There shouldn't be any pending connections to those intro points
 because we are parsing the fetched descriptor and making sure the IP
 entries in there are in the failure cache or not. After validation, if the
 intro node list is empty it means we can't use any thus we `goto err`. At
 that point, no new connections have been established to those intro points
 nor are already established.
 >
 > Hm. I think I meant connection_edge connections from the client?
 >

 On error, if the store function fails, the edge connection is closed so
 that extra new goto err is fine. `RCS_BADDESC` is sent back.

 Ok I fixed everything else in branch: `bug16389_027_02`.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16389#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online