[tor-bugs] #16288 [Tor]: The open file limit is not checked before calling tor_accept_socket_nonblocking()

[Tor Bug Tracker & Wiki]

#16288: The open file limit is not checked before calling
tor_accept_socket_nonblocking()
-------------------------+--------------------------------
     Reporter:  dgoulet  |      Owner:
         Type:  defect   |     Status:  needs_review
     Priority:  major    |  Milestone:  Tor: 0.2.7.x-final
    Component:  Tor      |    Version:
   Resolution:           |   Keywords:  026-backport
Actual Points:           |  Parent ID:
       Points:           |
-------------------------+--------------------------------
Changes (by dgoulet):

 * status:  needs_revision => needs_review


Comment:

 Replying to [comment:6 nickm]:
 > Oh, one more thing:
 >
 > If getrlimit succeeds but setrlimit fails, shouldn't we adjust
 max_sockets in that case?

 Yes I agree, especially if the current limit is below the default, that is
 important. I also moved a check at the top else we could have ended up in
 a having `max_sockets` negative.

 FYI, this branch has been running on my relay for the last 2 weeks and no
 problem at all. Bonus, I don't have a zillion log message telling me that
 I can't open more sockets and also tor doesn't fail anymore when trying to
 write the state or HS stats file (which it used to be the case a lot).

 Branch: `bug16288_027_03`

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16288#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online