[tor-bugs] #16393 [Tor]: Include a readpassphrase implementation for Linux, Windows
Tor Bug Tracker & Wiki
blackhole at torproject.org
Thu Jun 25 14:39:33 UTC 2015
#16393: Include a readpassphrase implementation for Linux, Windows
-----------------------------+--------------------------------
Reporter: nickm | Owner:
Type: enhancement | Status: needs_review
Priority: normal | Milestone: Tor: 0.2.7.x-final
Component: Tor | Version:
Resolution: | Keywords:
Actual Points: | Parent ID:
Points: |
-----------------------------+--------------------------------
Comment (by dgoulet):
* 771949a3e0fb4e4f9f0e049bf77833884ff7469c
Maybe we would want a `memwipe` (if we have a good one for Windows) here
since `buf` can potentially contain a passphrase? Yes could be malformed
passphrase but still could contain sensitive data.
{{{
memset(buf, 0, sizeof(wchar_t)*buflen);
}}}
The rest lgtm! FYI, I couldn't test it because of a lack of Windows
machine so this is a code ACK.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16393#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list